Unit-tests needed

[jaketmp]

The interfaces in JTPepub and ZipArchive need unit-tests.

[chrisridd]

I just pushed a change which adds some tests of JTPepub using the Untitled.epub.

I'm not 100% convinced by it, hence no pull request yet. What do you think?

chrisridd@9b622c617eebfa05ad02339f05ca5ed9b8267b95

[chrisridd]

Ah, I see you've added something too.

Things I'm not sure about:

• the whole schemes thing - adding a different "scheme" to run tests feels strange.
• there's lots of duplication of configuration in the two targets
• the test case has a poor name.
• One test case for each test file might be smarter.

[jaketmp]

Yeah - this was really just me playing round with the default unit-test target in Xcode, I'd only pushed it up to github because I wanted to put the note listing the UTI fix out there - should really have rolled the unit-test changes back before the sync.

I'm a fair novice at this unit testing stuff - I like the elegance of your approach, but half the point of this project is to force me to keep up-to-date with the intricacies of Xcode, so I may try to learn by doing in the Apple style.

One thing I can see is clear from your code is that the 'untitled.epub' needed an overhaul to account for all the new metadata, which I've now uploaded.

[jaketmp]

Did you create a new scheme to run your unit-tests? It would be good if you could tick 'Shared' under 'Manage Schemes' so it gets included in the commits (or I'm just missing something...)

[chrisridd]

Oh, I'd never noticed that option! OK, I've pushed a commit with that option changed.

[chrisridd]

Xcode doesn't seem to show anything as changed (wrt version control) when you change a scheme. Using "git status" from the command-line is more reliable.

[jaketmp]

I think it's safe to close this now.