search

jaketrent / html-webpack-template

a better default template for html-webpack-plugin
MIT License
830 stars 139 forks source link

Fix for #26 #27

Closed BrandonBoone closed 8 years ago

BrandonBoone commented 8 years ago

Allows you to pass a string or an object in the links array. Object properties and values will be converted to attributes and values on the generated link tags

jaketrent commented 8 years ago

@BrandonBoone I like it. Will you make sure that the changes are documented in the examples/ and the README, and we'll get this merged.

jaketrent commented 8 years ago

I'm planning on versioning this as a minor change because old-style links will still work. Let me know if you see something breaking that I don't.

BrandonBoone commented 8 years ago

Great, glad you like it! I updated the documentation. Let me know what you think.

Agreed, should be a minor update as the old-style links should still work. I tested it locally and everything seems to be backwards compatible.

jaketrent commented 8 years ago

Looking good, @BrandonBoone . Will you please add new usage to https://github.com/jaketrent/html-webpack-template/blob/master/examples/webpack.config.js as well?

BrandonBoone commented 8 years ago

I updated webpack.config.js. Let me know if you need anything else.

jaketrent commented 8 years ago

Published in v5.3.0