search

jaketrent / html-webpack-template

a better default template for html-webpack-plugin
MIT License
830 stars 139 forks source link

NPM packages include .idea directory #58

Closed edmorley closed 6 years ago

edmorley commented 6 years ago

Hi!

Some of the published packages include an .idea/ directory, eg:

$ curl -sSfL https://registry.npmjs.org/html-webpack-template/-/html-webpack-template-5.5.1.tgz  | tar -zt | grep '.idea'
package/.idea/.name
package/.idea/html-webpack-template.iml
package/.idea/jsLibraryMappings.xml
package/.idea/libraries/html_webpack_template_node_modules.xml
package/.idea/misc.xml
package/.idea/modules.xml
package/.idea/vcs.xml
package/.idea/workspace.xml

I think it would make sense to add this directory to .npmignore.

edmorley commented 6 years ago

Actually it looks like there isn't an existing .npmignore and that the .gitignore is being used as a fallback. As such, just adding the .idea directory to .gitignore should be sufficient :-)

jaketrent commented 6 years ago

Thanks for seeing this. Added .npmignore with .idea in it.