search

jaketrent / html-webpack-template

a better default template for html-webpack-plugin
MIT License
830 stars 139 forks source link

Please add support for html-webpack-plugin 4 #84

Open kamthamc opened 4 years ago

kamthamc commented 4 years ago

html-webpack-plugin 4 has been released. Please add support/upgrade the peer dependencies.

https://dev.to/jantimon/html-webpack-plugin-4-has-been-released-125d

mmaday commented 4 years ago

This template is not compatible with html-webpack-plugin v4 because the htmlWebpackPlugin.files object has changed. Refer to https://github.com/jantimon/html-webpack-plugin/issues/1369 for more details.

skipjack commented 4 years ago

This is unfortunate especially as it fails silently, just bumped to html-webpack-plugin@4.x and all of a sudden the site comes up blank (as no scripts are inserted).

bj00rn commented 3 years ago

Are there any ambitions to get fixed?

html-webpack-plugin is currently at v5

If this is a won't fix maybe add disclaimer to the README that this only supports html-webpack-plugin 3 to avoid any confusion and further discussion.

Thanks for great work! 🌷

jaketrent commented 3 years ago

@bj00rn Thanks for the note and question. I appreciate your directness and tact.

I do not have a lot of ambition to open personal bandwidth to update this atm. I would be happy to open add someone as a contributor to the repo or transfer it to an owner of interest and ability. Who is interested in making such contributions?

bj00rn commented 3 years ago

@bj00rn Thanks for the note and question. I appreciate your directness and tact.

I do not have a lot of ambition to open personal bandwidth to update this atm. I would be happy to open add someone as a contributor to the repo or transfer it to an owner of interest and ability. Who is interested in making such contributions?

Understood!

Fixed a typo for you in #88 , im guessing you mean html-webpack-plugin @ v3, not webpack @ v3

edit: maybe it wasn't a typo, but html-webpack-plugin makes it more obvious that it's not compatible anymore. html-webpack-plugin docs links to this lib...

Cheers!