jakev / dtfmods-core

Core content for Android device testing
Apache License 2.0
6 stars 2 forks source link

Change 'diff' modules to be less AOSP-focused #31

Closed jakev closed 8 years ago

jakev commented 9 years ago

Affected Module(s): sysappdb, frameworkdb, appdexdb, frameworkdexdb

The diffing modules refer to diffing as being against the AOSP data, which is true, but this is just a default behavior. Most (soon to be all) of these modules actually support arbitrary diffing as is, using the horribly named dtf property 'Local\aosp-data-dir'. This is confusing. Even to me.

The property will be moved, and all modules need to be adjusted to indicate that diffing is default against the AOSP, but can be set to anything. This is really just a huge bit of changing variable names, usage, etc.

The new property is called "Local\diff-data-dir", and all modules will need to be adjusted.

jakev commented 8 years ago

Most (if not all?) reference of only diffing against AOSP has been removed as of 1.3. The latest commit cleaned up sysappdb: https://github.com/jakev/dtfmods-core/commit/356020dbb59c4cb3f0365ac4ebd39f30005380fd.