jakewies / hugo-theme-codex

A minimal blog theme for Hugo 🍜
https://themes.gohugo.io/themes/hugo-theme-codex/
MIT License
334 stars 187 forks source link

Advanced Opengraph Support #89

Open ProfessorLogout opened 4 years ago

ProfessorLogout commented 4 years ago

As discussed in #82 For the moment just some quick notes on how we can do this:

This are just some quick notes early in the morning from mobile, excuse my formatting. Happy for comments, I will update once I can try this later today.

@msfjarvis @jakewies

msfjarvis commented 4 years ago

Looks good, happy to help with any changes to my module.

jakewies commented 4 years ago

Would this mean that hugo-social-metadata would need to be refactored to include an opengraph.html template in order to override the opengraph.html template in the theme?

Just peaked into @msfjarvis project and the template is named social_metadata.html.

I'm on board with this. The first two steps wouldn't include any new changes to this project other than prepping for optional functionality from hugo-social-metadata. We would need to update the README to document how it's done.

It would also mean changing our documentation on how to install this project I think? Since now we document adding it as a git submodule instead of a Hugo module.

EDIT: Sorry on mobile, now I see we can tell users to submodule both themes and just declare them as normal but put hugo-social-metadata first. Got it. I wouldn't mind considering Hugo modules as an additional improvement here. What do you all think about the submodule vs Hugo module declaration approach?

iamericfletcher commented 4 years ago

Would this mean that hugo-social-metadata would need to be refactored to include an opengraph.html template in order to override the opengraph.html template in the theme?

Just peaked into @msfjarvis project and the template is named social_metadata.html.

I'm on board with this. The first two steps wouldn't include any new changes to this project other than prepping for optional functionality from hugo-social-metadata. We would need to update the README to document how it's done.

It would also mean changing our documentation on how to install this project I think? Since now we document adding it as a git submodule instead of a Hugo module.

EDIT: Sorry on mobile, now I see we can tell users to submodule both themes and just declare them as normal but put hugo-social-metadata first. Got it. I wouldn't mind considering Hugo modules as an additional improvement here. What do you all think about the submodule vs Hugo module declaration approach?

Looking forward to using and sharing this enhancement. Thank you.