search

jakewins / brew

Maven plugin for compiling coffeescript, haml-js and aggregating AMD-based js projects.
GNU Lesser General Public License v2.1
91 stars 21 forks source link

here's a minor compile fix & a fix to allow resources to be copied as part of the compile (rather than just watch) and deal with non-existing target directories #12

Open jstrachan opened 12 years ago

jakewins commented 12 years ago

I know test coverage in this project is so-so, so I feel bad asking since I'm not really walking the walk.. but could you add a small test case, to make sure these improvements don't get broken further down the road?

It should be possible to create another integration test project, or extend one that already exists, that would have failed before this change, see here: https://github.com/jakewins/brew/tree/master/src/functionaltest/testprojects

Looked through the code as well, looks really good, thank you so much for contributing. Will pull in as soon as a test has been added to the project.

jstrachan commented 12 years ago

Agreed :)

Yeah; I'm trying to hack in CoffeeJade support at the moment... https://github.com/fusesource/coffeejade

Will add an integration test in there using new directories as part of that new integration test.

On 2 December 2011 12:00, Jacob Hansson reply@reply.github.com wrote:

I know test coverage in this project is so-so, so I feel bad asking since I'm not really walking the walk.. but could you add a small test case, to make sure these improvements don't get broken further down the road?

It should be possible to create another integration test project, or extend one that already exists, that would have failed before this change, see here: https://github.com/jakewins/brew/tree/master/src/functionaltest/testprojects

Looked through the code as well, looks really good, thank you so much for contributing. Will pull in as soon as a test has been added to the project.

Reply to this email directly or view it on GitHub: https://github.com/jakewins/brew/pull/12#issuecomment-2989241

James

FuseSource Email: james@fusesource.com Web: http://fusesource.com Twitter: jstrachan Blog: http://macstrac.blogspot.com/

Open Source Integration