jakex7 / react-native-localization-settings

React Native module to expose per-app language preferences API on iOS and Android.
MIT License
71 stars 15 forks source link

BUG / FEEDBACK: App Language Set to Value instead of Keeping System Default Inexplicably #4

Open elibroftw opened 1 year ago

elibroftw commented 1 year ago

Unless explicitly specified, do not set the app language to the value of the system default, just leave it as "System default". It wastes time debugging why the app isn't recognizing the locale and it will mess up users who want to change their language to another one if the user never set a specific language through the app itself.

image

elibroftw commented 1 year ago

It's okay though, tbh, apps should open the settings app instead of doing it themselves. I'll remove the library. I was using it just for the language detector.

7ammer commented 6 months ago

I would also appreciate this. Being able to set to "System default" would be extremely useful.

jakex7 commented 3 days ago

I'd love to! Actually, this library doesn’t behave that way. Unfortunately, the default behavior of i18next is to call cacheUserLanguage on the language detector (that this library exposes) both at startup and whenever the user selects a different language. There's no way to distinguish between these two events.