jakezatecky / react-dual-listbox

A feature-rich dual listbox for React.
https://jakezatecky.github.io/react-dual-listbox/
MIT License
109 stars 58 forks source link

Filtering and then moving all options moves all filtered-out options as well #268

Closed lmendezr closed 7 months ago

lmendezr commented 7 months ago

Describe the bug Filtering and then moving "all" items is also moving filtered-out options.

Reproduction steps

CodeSandbox example

Expected behavior Only visible options should be moved.

Note - This works as expected from left-to-right if you move them all back to the "filtered side" and try again without changing the filter. Does not work at all from right-to-left.

Screenshots I grabbed a quick clip showcasing the bug in action: https://www.loom.com/share/d7e6dab07847452699b59602bc126f63?sid=2831facb-0bd6-4bea-a034-8c30e78269dd

jakezatecky commented 7 months ago

Thank you for the the high quality bug report. This is indeed unexpected behavior.

lmendezr commented 7 months ago

Thanks @jakezatecky for verifying!

jakezatecky commented 7 months ago

Resolved in 9901290309a621b706e3d6ff7cca03579e878cdd and available in version 6,0.3.

lmendezr commented 7 months ago

Awesome, I can confirm it now works as expected. Thanks a lot for the speedy fix, @jakezatecky!