search

jakiestfu / Medium.js

A tiny JavaScript library for making contenteditable beautiful (Like Medium's editor)
http://jakiestfu.github.io/Medium.js/
4.39k stars 404 forks source link

modifiers bold/underline/italic etc. only work on selections? #183

Open ktiedt opened 8 years ago

ktiedt commented 8 years ago

On your demo page, I was really confused why ctrl+b etc was not modifying any text I was typing... later I came back and tried to select text and try it that way... it appears to only work on selections, that seems like not the intended behavior for a supposed RTE?

robertleeplummerjr commented 8 years ago

Can you clarify which of the instances it did/didn't work on? Also, if you run the unit tests (click the green check in your browsers) and let us know which items are failing, it helps us to identify the problem.

On Mon, Feb 8, 2016 at 5:21 PM, Karl Tiedt notifications@github.com wrote:

On your demo page, I was really confused why ctrl+b etc was not modifying any text I was typing... later I came back and tried to select text and try it that way... it appears to only work on selections, that seems like not the intended behavior for a supposed RTE?

— Reply to this email directly or view it on GitHub https://github.com/jakiestfu/Medium.js/issues/183.

Robert Plummer

ktiedt commented 8 years ago

In any rich demo... No keyboard shortcuts worked in latest chrome excep unless you selected text first so General typing... It would fail. I'll see about running tests at work tomorrow On Feb 8, 2016 17:14, "Robert Plummer" notifications@github.com wrote:

Can you clarify which of the instances it did/didn't work on? Also, if you run the unit tests (click the green check in your browsers) and let us know which items are failing, it helps us to identify the problem.

On Mon, Feb 8, 2016 at 5:21 PM, Karl Tiedt notifications@github.com wrote:

On your demo page, I was really confused why ctrl+b etc was not modifying any text I was typing... later I came back and tried to select text and try it that way... it appears to only work on selections, that seems like not the intended behavior for a supposed RTE?

— Reply to this email directly or view it on GitHub https://github.com/jakiestfu/Medium.js/issues/183.

Robert Plummer

— Reply to this email directly or view it on GitHub https://github.com/jakiestfu/Medium.js/issues/183#issuecomment-181655434 .

robertleeplummerjr commented 8 years ago

Awesome for finding it. I will look at it as soon as I have a chance.

On Mon, Feb 8, 2016 at 8:19 PM, Karl Tiedt notifications@github.com wrote:

In any rich demo... No keyboard shortcuts worked in latest chrome excep unless you selected text first so General typing... It would fail. I'll see about running tests at work tomorrow On Feb 8, 2016 17:14, "Robert Plummer" notifications@github.com wrote:

Can you clarify which of the instances it did/didn't work on? Also, if you run the unit tests (click the green check in your browsers) and let us know which items are failing, it helps us to identify the problem.

On Mon, Feb 8, 2016 at 5:21 PM, Karl Tiedt notifications@github.com wrote:

On your demo page, I was really confused why ctrl+b etc was not modifying any text I was typing... later I came back and tried to select text and try it that way... it appears to only work on selections, that seems like not the intended behavior for a supposed RTE?

— Reply to this email directly or view it on GitHub https://github.com/jakiestfu/Medium.js/issues/183.

Robert Plummer

— Reply to this email directly or view it on GitHub < https://github.com/jakiestfu/Medium.js/issues/183#issuecomment-181655434> .

— Reply to this email directly or view it on GitHub https://github.com/jakiestfu/Medium.js/issues/183#issuecomment-181656345 .

Robert Plummer