search

jakiestfu / Youtube-TV

A small, slick, library independent YouTube User/Playlist player
https://github.com/jakiestfu/Youtube-TV#demos
205 stars 125 forks source link

All hell breaks loose in damn near all versions of IE #1

Open jakiestfu opened 11 years ago

jakiestfu commented 11 years ago

There are many issues with this code on IE, both visually and technically. Would love some help on the CSS issues!

xebec commented 11 years ago

IE does not understand target.dataset and that's why is not changing the video when clicking on any li element. http://stackoverflow.com/questions/7127896/problem-using-elem-dataset-with-ie-and-jsfiddle.

stefenphelps commented 11 years ago

The latest version works on IE10 and up.

StanTheRebel commented 10 years ago

Anyone working on this?

elohimito commented 10 years ago

Is there any hope of getting this updated to work with older versions of IE? Or am I wasting my time waiting...Anyone? Bueller?

christopheraram commented 10 years ago

I poked around with the Ajax and was able to get it working in IE 8 and 9. I have not tested earlier versions. Also, "getElementsByClassName" does not work in ie8, requiring use of "querySelectorAll" instead.

elohimito commented 10 years ago

@christopheraram What did you do to make it work?

christopheraram commented 10 years ago

@elohimito the Ajax was mostly there, but required some tweaks to get it working in IE 8/9. I tested using jQuery .ajax() which worked since it's quick and easy that way (and what I'm most familiar with). I hit up MSDN for my reference and modified the ajax: method of YoutubeTV using standard JS. I'm unsure of how it works in IE7 and below since I can't remember if I tested for that or not...

Either way... I'll see about forking and making a IE fix branch. I think more "getElementsByClassName" need to be replaced with the "querySelectorAll". After I do some of that I can do some more testing and see about getting a fix uploaded. I'll see what can be done with the CSS.

mtamony commented 10 years ago

Any ideas for IE? This plugin doesn't work in 10 correctly and Compatibility mode is a total wreck. I hate IE.

mtamony commented 10 years ago

@christopheraram Did you ever get this working in IE 8 or 9? 7?

bradleywest92 commented 10 years ago

@christopheraram Hi Chris, did you ever get this working in IE at all?

wwk3j commented 10 years ago

@bradleywest92 @christopheraram did you guys ever get it working in IE any versions or find a workaround? I tried replacing the ajax.get with ajax and then type:GET and url:the endpoint and then switching out the getElementsByClassName with querySelectorAll, but it didn't seem to work.

developwisely commented 9 years ago

Oddly enough, I have it working in IE8-edge and Chrome, but I can't get it to load in Firefox at all.

All I had to change to get it working in IE was what was stated above: change all the getElementsByClassName to querySelectorAll. NOTE: you have to change the class name in the parenthesis too. [e.g. getElementByClassName('ytv-list-header') then becomes querySelectorAll('.ytv-list-header) -- note the period added]

This change alone got it working in IE8+ for me. Also note, I'm using it as a jQuery plugin too, and haven't tested the others fully.

wwk3j commented 9 years ago

Thanks for the response. I made the change, but it still does not work for me in IE, but in Chrome and Firefox it works fine. Although I am using it as a jQuery library.