jakipatryk / spark-persistent-homology

(WIP, not fast enough for any production usage yet) Library for persistent homology computations in Apache Spark.
Apache License 2.0
0 stars 0 forks source link

Convert type aliases to value classes #16

Closed jakipatryk closed 1 year ago

jakipatryk commented 1 year ago

As value classes don't have any runtime overhead (in general, more in https://docs.scala-lang.org/sips/value-classes.html), but provide compile time benefits, they should be used instead of type aliases.

For example, currently in the project there is:

type Filtration = RDD[(IndexInMatrix, InitThreshold, SimplexBoundary)]

that should be converted to something like:

case class Filtration(rdd: RDD[(IndexInMatrix, InitThreshold, SimplexBoundary)]) extends AnyVal