search

jakirkham / miniforge

A constructor-based builder for a basic conda-forge installer
BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

Specify the `Content-Length` header for uploads #36

Closed jakirkham closed 6 years ago

jakirkham commented 6 years ago

In Python 3.6, it appears there was a change that causes uploads to be chunked by default if the Content-Length is not specified. AFAIK this behavior is not supported by GitHub releases. It also results in the connection being closed and reopened while we still have it open triggering ConnectionResetErrors. To fix this, we send the Content-Length in the header after measuring it from the memory mapped file.

ref: https://bugs.python.org/issue12319

jakirkham commented 6 years ago

Windows Python 3.6 installers uploaded now! 🎉 Expect macOS installers should be up once they build as well (since all builds on macOS were using Python 3.6).