jakke-korpelainen / newtab-angular

Custom New Tab -page (AngularJs, RequireJS)
MIT License
99 stars 25 forks source link

Additional translations #14

Open jakke-korpelainen opened 9 years ago

jakke-korpelainen commented 9 years ago

If a translation is missing for your language, feel free to contribute :earth_americas:!

jakke-korpelainen commented 9 years ago

Added Traditional Chinese https://github.com/jakke-korpelainen/newtab/commit/93e60f4195628e4b109b93e8176f651c223cffa5 (Thanks to @kevinjcliao)

vanniktech commented 9 years ago

I'd like to throw some German translations in. However with the current structure it is not really possible since 'Good evening' is 'Guten Abend' however 'Good night' is 'Gute Nacht'. If you would like to have German translations, the model would need to be updated.

jakke-korpelainen commented 9 years ago

@vanniktech Ok great! It's sort of possible like this without changes into models;

{
    "morning" : "",
    "afternoon" : "",
    "day" : "",
    "evening" : "Guten abend",
    "night" : "Gute night",
    "good" : "",
    "today" : "",
    "is" : "",
    "greeting" : "{daystate} {name}, today is {date}"
}

Isn't a best practise so I'll try to come up with a more sophisticated solution.

vanniktech commented 9 years ago

Should I wait for you to make some changes or should I create the German translations and create a PR?

jakke-korpelainen commented 9 years ago

Feel free to create a PR, I'm going for a holiday tomorrow so I'll refactor the translations later this month :).

vanniktech commented 9 years ago

There you go https://github.com/jakke-korpelainen/newtab/pull/25

jakke-korpelainen commented 9 years ago

Merged, thanks!