search

jakkra / ZSWatch

ZSWatch - the Open Source Zephyr™ based Smartwatch, including both HW and FW.
https://forms.gle/G48Sm5zDe9aCaYtT9
GNU General Public License v3.0
2.28k stars 195 forks source link

Current Time Service (CTS) client #121

Closed ldab closed 10 months ago

ldab commented 10 months ago

This may also work for Android, I don't know, haven't tested

It seems like the clock is adjusting for DST, should I pass one hour less?

jakkra commented 10 months ago

As the timezone is currently hadrcoded here: https://github.com/jakkra/ZSWatch/blob/main/app/src/zsw_clock.c#L42 And I assume the time you get from iOS is already corrected we have this issue. Gadgetbridge time is not adjusted. So some solution is needed here to make both work.

ldab commented 10 months ago

As the timezone is currently hadrcoded here: https://github.com/jakkra/ZSWatch/blob/main/app/src/zsw_clock.c#L42 And I assume the time you get from iOS is already corrected we have this issue. Gadgetbridge time is not adjusted. So some solution is needed here to make both work.

Having the timezone hardcoded seems not appropriate, don’t you get it from the app?

jakkra commented 10 months ago

As the timezone is currently hadrcoded here: https://github.com/jakkra/ZSWatch/blob/main/app/src/zsw_clock.c#L42 And I assume the time you get from iOS is already corrected we have this issue. Gadgetbridge time is not adjusted. So some solution is needed here to make both work.

Having the timezone hardcoded seems not appropriate, don’t you get it from the app?

Yep, it's just TODO But seems to be there: image

ldab commented 10 months ago

As the timezone is currently hadrcoded here: https://github.com/jakkra/ZSWatch/blob/main/app/src/zsw_clock.c#L42 And I assume the time you get from iOS is already corrected we have this issue. Gadgetbridge time is not adjusted. So some solution is needed here to make both work.

Having the timezone hardcoded seems not appropriate, don’t you get it from the app?

Yep, it's just TODO But seems to be there: image

so it should be ok to merge this PR, it will fix when the todo is done