Upgrade to use astyle 3.4 in ci

jakkra / ZSWatch

ZSWatch - the Open Source Zephyr™ based Smartwatch, including both HW and FW.

https://forms.gle/G48Sm5zDe9aCaYtT9

GNU General Public License v3.0

2.28k stars 195 forks source link

Upgrade to use astyle 3.4 in ci #130

Closed jakkra closed 8 months ago

jakkra commented 10 months ago

The current astyle version in apt-get is 3.1 but the one users typically download from the web is the latest 3.4. There is some difference in 3.1 vs 3.4 in the way they format code, hence causing ci issues when user and ci don't have matching astyle version.

Also add instructions for Linux users how to download and install astyle 3.4 since apt-get uses an old version.

ldab commented 9 months ago

I do not see the astyle being updated on https://github.com/zephyrproject-rtos/docker-image/releases docker image

jakkra commented 9 months ago

@ldab We do astyle install through apt-get https://github.com/jakkra/ZSWatch/blob/main/.github/workflows/build.yml#L27.

This is unrelated to Zephyr version etc.

ldab commented 9 months ago

aaaaaaaaaaaaaaaaaaaaaa

Kampi commented 8 months ago

@jakkra I added the build and installation of AStyle 3.4 to the development container. Can you add these commands to the CI/CD pipeline too?

wget https://sourceforge.net/projects/astyle/files/astyle/astyle%203.4/astyle-3.4.10.tar.bz2/download -O astyle.tar.bz2
tar -xf astyle.tar.bz2
cd astyle-3.4.10
mkdir as-gcc-exe
cd as-gcc-exe
cmake ../
make