search

jakkra / ZSWatch

ZSWatch - the Open Source Zephyr™ based Smartwatch, including both HW and FW.
https://forms.gle/G48Sm5zDe9aCaYtT9
GNU General Public License v3.0
2.26k stars 191 forks source link

Flick In event don´t put the device into inactive mode when the display always on is enabled #163

Closed Kampi closed 8 months ago

ldab commented 8 months ago

It works for me, when looking at you did, I was expecting to get the settings by example settings_storage_get() but whatever you did, works haha.

Hold on... doesn't work here, I think the debugger was keeping the screen on

jakkra commented 8 months ago

@ldab this PR should be OK, at least from looking at it. It's a different feature if apps want to keep the screen from going to sleep. That would be implemented some other way. It should not control it though settings, this should be done in another way

Kampi commented 8 months ago

~It works for me~, when looking at you did, I was expecting to get the settings by example settings_storage_get() but whatever you did, ~works haha~.

Hold on... doesn't work here, I think the debugger was keeping the screen on

Are you sure? I tested it again and the screen on my watch has been active for ~2h now, even with flick events. Also, it's more of a "dirty" fix, because (as @jakkra mentioned it) there is only a global option to disable screen off in the settings and I have added a check for it. The better solution is to add some sort of API for apps to prevent it. I added it as Issue (#164 ).