jakkra / ZSWatch

ZSWatch - the Open Source Zephyr™ based Smartwatch, including both HW and FW.
https://forms.gle/G48Sm5zDe9aCaYtT9
GNU General Public License v3.0
2.18k stars 178 forks source link

Issue with wrong hours in new watch faces #272

Open Kampi opened 1 month ago

Kampi commented 1 month ago

The hours arent´set correctly. If you have a flip from i. e. 23 oclock to 5 oclock because of a watchface activation at this time points, the leading 2 isn´t deleted which results in 25 o`clock.

My guess is that this issue comes from this line in the generated code:

https://github.com/jakkra/ZSWatch/blob/684d88b40d7297c20686fd16d79102b8d2b129b0/app/src/ui/watchfaces/73_2_dial/zsw_watchface_73_2_dial_ui.c#L338

I think an additional else where the image source for the number 0 is loaded should fix the issue.

jakkra commented 1 month ago

Will check it out

jakkra commented 1 month ago

Your example seems to work, will debug more Screencast from 2024-05-13 11:34:33.webm

Kampi commented 1 month ago

@jakkra I think this is already fixed, isn´t it?

jakkra commented 1 month ago

@jakkra I think this is already fixed, isn´t it?

Nope, had it yesterday. Needs debugging