jakob101 / RelativePathRefactor

A plugin for VSCode
https://marketplace.visualstudio.com/items?itemName=jakob101.relativepathrefactor
5 stars 1 forks source link

Double quotes are used regardless of the configuration #1

Open karol-majewski opened 7 years ago

karol-majewski commented 7 years ago

Hello and thank you for your work!

One thing I've noticed is this: when Fix relative paths is applied, it wraps newly generated path into double quotes, regardless of the convention in use.

// Before
import Styles from './Back.css';

After hitting Fix relative paths:

// Error: [eslint] Strings must use singlequote. (quotes)
import Styles from "../js/components/Back.css"; 

The expected behavior would be to use the kind of quotes that were used before fixing the path.

Setup

aqzhyi commented 7 years ago

+1 this

my case

before:

import { ControlsComponent } from './controls'

after:

import { ControlsComponent } from "./controls/controls"

cause [tslint] " should be ' (quotemark)

jakob101 commented 7 years ago

I see. Thanks guys! Will try to take a look. 

On Sat, Jan 7, 2017 at 6:04 PM +0100, "Pleasurazy.LZ.C" notifications@github.com wrote:

+1 this

my case

before:

import { ControlsComponent } from './controls'

after:

import { ControlsComponent } from "./controls/controls"

cause [tslint] " should be ' (quotemark)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

ReDrUm commented 7 years ago

👍 I too would love it to respect the originally used quote character. Or alternatively let us configure it.

jakob101 commented 7 years ago

Wanna try a PR?