search

jakobbossek / smoof

Single- and Multi-Objective Optimization Test Functions
http://jakobbossek.github.io/smoof/
Other
36 stars 16 forks source link

Corrected class and attr lines #141

Closed jeroenrook closed 2 years ago

jeroenrook commented 2 years ago

Succesfully ran tests with devtools::test() after changes

jakobbossek commented 2 years ago

Thanks Jeroen. Do you have any idea why test-coverage fails? It seems to be reticulate/python issue.

jeroenrook commented 2 years ago

Did that test ran on my system? I that case it had to do with conflicting architectures. R uses arm64 and Python X86_64 which causes problems when one calls the other internally. I changed Python now to a version that is based on arm64 and that works: 

ℹ Loading smoof
Loading required package: ParamHelpers
Loading required package: checkmate
ℹ Testing smoof
✔ | F W S  OK | Context
✔ |         7 | Expected Running  Time                                                                                                                                                               
✔ |        20 | conversion of minimization to maximization problem and vice versa                                                                                                                   
✔ |         6 | counting evaluations                                                                                                                                                                
✔ |        18 | function filtering works well [0.2s]                                                                                                                                                
✔ |        99 | test some getter and setter functions [0.6s]                                                                                                                                        
✔ |         6 | isMultiobjective/isSingleObjective                                                                                                                                                  
✔ |        89 | logging x and y values                                                                                                                                                              
✔ |         7 | makeFunctionsByName helper                                                                                                                                                          
✔ |         2 | makeMultiObjectiveFunction                                                                                                                                                          
✔ |        54 | makeSingleObjectiveFunction                                                                                                                                                         
✔ |        59 | autoplot function [2.4s]                                                                                                                                                            
✔ |         4 | shortcut functions, i.e., snof and smof                                                                                                                                             
✔ |       1719 | single-objective test functions [4.7s]                                                                                                                                             
✔ |         5 | violatesConstraints                                                                                                                                                                 

══ Result ════════════════════════════════════════════════
Duration: 8.2 s

[ FAIL 0 | WARN 0 | SKIP 0 | PASS 2095 ]
jakobbossek commented 2 years ago

No, the test runs on the CI-system. However, you did not change anything in the CI-system configuration. Let's merge now and deal with it later.