search

jakobhellermann / bevy-inspector-egui

Inspector plugin for the bevy game engine
Apache License 2.0
1.18k stars 173 forks source link

Update to bevy 0.13, egui 0.26, and more #185

Closed Aztro-dev closed 7 months ago

theshortcut commented 7 months ago

Agreed with @RobWalt that this would be great to get out, some of the examples still need some updates I think in particular due to the exposure changes a lot of the example scenes probably need some lighting updates. For example the egui_dock example now looks like this:

image

Tweaking the PointLight intensity from 25.0 to 12000.0 and the DirectionalLight illuminance down to 2000.0 gets the scene looking a little more like it used to though the ceiling emissive plane still looks very wrong:

image

Aztro-dev commented 7 months ago

The only example I have yet to fix (that I know of) is the egui-dock example, as I get a fatal error on my Laptop (M2 MacBook Air), but once I get home from school I can devote more time to fixing the example. If anyone can suggest a change then I could add it to the pull request.

I will also later make an issue for the problem that I am having, but that will also happen when I get home.

kaosat-dev commented 7 months ago

@theshortcut I believe emissive materials are broken in V0.13, based on my migration work today . Currently working on a minimalist example to create an issue on the Bevy repo

Aztro-dev commented 7 months ago

I updated the final example (egui_dock) to be more like the original, but I encourage others to compare the differences between the original and new examples.

Aztro-dev commented 7 months ago

Should we just merge? I think the examples are fine, and a lot of crates are waiting for this PR to go through.

jakobhellermann commented 7 months ago

I was just about to take a look at the PR. Looks good to me, and thanks for doing the update :heart: