search

jakobhellermann / bevy-inspector-egui

Inspector plugin for the bevy game engine
Apache License 2.0
1.18k stars 173 forks source link

Update to bevy 0.14 #197

Closed kristoff3r closed 3 months ago

kristoff3r commented 3 months ago

This seems to work, but it's missing color pickers for all the new color spaces introduced. Also I haven't ensured that the ranges for color grading is correct nor tested those, as I'm not at all familiar with the math or terminology.

kristoff3r commented 3 months ago

I can't reproduce the test failures locally :/

tychedelia commented 3 months ago

but it's missing color pickers for all the new color spaces introduced

I think it's okay to just add color pickers for the Srgba and Hsva structs rather than for the entire color enum.

Azorlogh commented 3 months ago

The Debug impl for Entity became more verbose in 0.14 which now leads to this result image I think we should change these two lines to use "{}" instead of "{:?}": https://github.com/jakobhellermann/bevy-inspector-egui/blob/13dfde5830ea8b7ffadb9d1db5c2265a5ca9f1f4/crates/bevy-inspector-egui/src/utils.rs#L25 https://github.com/jakobhellermann/bevy-inspector-egui/blob/13dfde5830ea8b7ffadb9d1db5c2265a5ca9f1f4/crates/bevy-inspector-egui/src/utils.rs#L47

tychedelia commented 3 months ago

blocked on https://github.com/mvlabat/bevy_egui/pull/284#issuecomment-2209484527

tomara-x commented 3 months ago

bevy_egui 0.28 is out now

jakobhellermann commented 3 months ago

Thanks for the PR, I'll take a look and merge tomorrow

kristoff3r commented 3 months ago

Hmm, bevy_egui bumped both the egui version and the bevy version in the same release, and egui-dropdown and transform-gizmo-egui still haven't updated.

kristoff3r commented 3 months ago

I inlined egui-dropdown to test, it was very easy to update. I'm not sure if we should do a PR and ping the author or just keep it, it's a very small dependency.

jakobhellermann commented 3 months ago

Thanks a lot for the PR! Everything looks good to me