jakobhellermann / bevy-inspector-egui

Inspector plugin for the bevy game engine
Apache License 2.0
1.19k stars 173 forks source link

add vec_as_dropdown example #22

Closed rezural closed 3 years ago

rezural commented 3 years ago

Hey, Loving the inspector.

This wasn't obvious for me as a first time user, and would seems to be a fairly common use case. Hopefully it helps someone else..

VecAsDropdown works over a Vec of T: Clone + Display + PartialEq + Debug + Default,

from the code:

impl<T> Inspectable for VecAsDropdown<T>
where
    T: Clone + Display + PartialEq + Debug + Default,
{
    type Attributes = Vec<T>;

Thanks!

jakobhellermann commented 3 years ago

Thanks for the PR! Please run cargo fmt and I'll merge.

rezural commented 3 years ago

Hey, thanks.

I ran a cargo fmt, and it touches alot of other files as well (it doesn actually touch the vec_as_dropdown.rs):

On branch vec-as-dropdown
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
    modified:   examples/demo.rs
    modified:   examples/enum.rs
    modified:   examples/planet_demo.rs
    modified:   examples/quaternion.rs
    modified:   examples/rust_types.rs
    modified:   examples/transform.rs
    modified:   src/impls/bevy_impls.rs
    modified:   src/impls/list.rs
    modified:   src/impls/number.rs
    modified:   src/impls/primitives.rs
    modified:   src/impls/quat.rs
    modified:   src/impls/rapier/nalgebra_impls.rs
    modified:   src/impls/rapier/rapier2d_impls.rs
    modified:   src/impls/rapier/rapier_impls.rs
    modified:   src/impls/vec.rs
    modified:   src/impls/with_context.rs
    modified:   src/lib.rs
    modified:   src/plugin.rs
    modified:   src/reflect/mod.rs
    modified:   src/utils/macros.rs
    modified:   src/utils/mod.rs
    modified:   src/utils/sort_if.rs
    modified:   src/utils/ui.rs
    modified:   src/widgets/button.rs
    modified:   src/widgets/new_window.rs
    modified:   src/widgets/resource_inspector.rs
    modified:   src/world_inspector/inspectable_registry.rs
    modified:   src/world_inspector/mod.rs
    modified:   src/world_inspector/plugin.rs

I think that actions are only triggered for pull requests, and you may have snuck in some unformatted code.

Thanks

jakobhellermann commented 3 years ago

Weird, cargo fmt changes nothing locally for me. I'll just merge and then format myself.