search

jakobhellermann / bevy-inspector-egui

Inspector plugin for the bevy game engine
Apache License 2.0
1.19k stars 173 forks source link

Make bevy_ui dependency optional #52

Closed Shatur closed 2 years ago

Shatur commented 2 years ago

Currently bevy_ui is on a very early stage and most people use egui for ui. So I suggest to make bevy_ui optional.

jakobhellermann commented 2 years ago

Yeah, currently bevy-inspector-egui unconditionally depends on "bevy_render", "bevy_pbr", "bevy_sprite", "bevy_text", "bevy_ui". It makes sense to put those behind feature flags, but probably enabled by default.

I wish cargo had some concept of transitive features where bevy-inspector-egui could detect whether the user has features enabled on bevy and act accordingly, but default features should be good enough here.

Will implement this before the release updating to bevy 0.7 :+1:

Shatur commented 2 years ago

It makes sense to put those behind feature flags, but probably enabled by default.

It would be great!

Will implement this before the release updating to bevy 0.7 +1

Looking forward to it!

jakobhellermann commented 2 years ago

Done and released in 0.10