search

jakobhellermann / bevy-inspector-egui

Inspector plugin for the bevy game engine
Apache License 2.0
1.15k stars 169 forks source link

export `bevy_egui/immutable_ctx` feature #68

Closed YoshieraHuang closed 2 years ago

jakobhellermann commented 2 years ago

Thanks for the PR.

Since bevy_egui exposes some other features as well and bevy-inspector-egui doesn't actually care which ones are enabled I wonder whether it would be better to not forward those at all and instead require the users to enable them manually by depending on bevy_egui directly.

bevy_egui = { version = "...", features = ["immutable_ctx"] }
bevy-inspector-egui = "..."

Would that also work for you?

YoshieraHuang commented 2 years ago

Thanks for the PR.

Since bevy_egui exposes some other features as well and bevy-inspector-egui doesn't actually care which ones are enabled I wonder whether it would be better to not forward those at all and instead require the users to enable them manually by depending on bevy_egui directly.

bevy_egui = { version = "...", features = ["immutable_ctx"] }
bevy-inspector-egui = "..."

Would that also work for you?

This works for me and i learn a new trick. Thank you very much. I will close this PR.