jakobilobi / wsstat

Check the status of a WebSocket endpoint.
MIT License
5 stars 1 forks source link

Added working snapcraft.yaml package definition #3

Closed erik78se closed 5 months ago

erik78se commented 5 months ago

This builds a snap package out of the tool.

Feel free to include this if you find it useful and hopefully you would consider publish the snap at snapcraft.io.

If you do, I would appreciate if you added me to an ATTRIBUTION file.

To build the snap on lxd, simply "snapcraft pack --use-lxd"

jakobilobi commented 5 months ago

Tested out the LXD build command, works well :+1:

Questions:

  1. This is the name of the produced snap: wsstat_v0.1.1-1-g5759ee8a14-5759ee8_amd64.snap. The hash 5759ee8 is of the latest commit on the main branch, so it makes sense that it's there but is it needed twice? And where does the 1-g in front of the first hash come from?
  2. It automatically builds for amd64, presumable since that's what I'm running, but would it make sense to make snapcraft build for additional archs? Especially if it's to be published on snapcraft.io.
jakobilobi commented 5 months ago

Conclusions from Slack huddle on this topic:

erik78se commented 5 months ago

LGTM