jakobkmar / pacmc

An easy-to-use package manager (and soon to be launcher) for Minecraft mods.
GNU Affero General Public License v3.0
122 stars 9 forks source link

[Feature Request] Prompt users whether to install optional dependencies #55

Open mooziii opened 2 years ago

mooziii commented 2 years ago

title says it Example:

Do you want to install any optional dependencies?
1) modrinth/modmenu
2) modrinth/clothconfig
3) modrinth/fabric-api

List the dependencies that you want to install (provide the numbers): 2,3

^^^ this would install clothconfig and fabric api but not modmenu

jakobkmar commented 2 years ago

Do you think this prompt should be default behaviour or only appear with a special flag?

mooziii commented 2 years ago

Should be default

sparrowofsong commented 2 years ago

I agree; I'm using quilt, which replaces fabric api with qsl if I'm not mistaken, so automatically installing fabric api (and not allowing the user to remove it) doesn't work well in that case

jakobkmar commented 2 years ago

@sparrowofsong that's another issue, fabric-api is not an optional dependency in that case, but a required one - this issue is about optional dependencies not being installed at all at the moment