search

jakobkroeker / test_singular

manage a personal issue list for Singular CAS
0 stars 0 forks source link

removed error messages in 'primdec.lib' #144

Open jakobkroeker opened 9 years ago

jakobkroeker commented 9 years ago

in 'primdec.lib' lines 9020,9076, 9083, 9102, 9114 error messages were replaced by simple text messages in commit

https://github.com/Singular/Sources/commit/584649e7d56725619ab0a2ed50ec5fd4f180e711

That is an issue, especially because it is in general not possible to handle an error case in automated tests, if no error or warning is triggered.

  1. Revert that change.
  2. Remove never reached statements following the error message.
jakobkroeker commented 9 years ago

changes party reverted in https://github.com/Singular/Sources/commit/1d0b91fbec50d1a0fc884eb1fe44cf48dfd0ff8e

not reverted:

 if (patchPrimaryDecomposition && size(L)==0 )
  {
     "// will not handle case with unit ideal";
  }

Question: how absPrimdecGTZ() should behave for unit ideal input? offtopic: "//factorization error" should be a hard error, too