search

jakoblind / webpack-autoconf

A tool to create frontend apps using webpack, Parcel or Snowpack
https://createapp.dev/
876 stars 78 forks source link

Feature/project name #95

Closed linus345 closed 4 years ago

linus345 commented 4 years ago

Closes #91

I chose to implement both a whitelist and use the third party library to validate the package name. The whitelist is used to ensure that only valid characters for directory names is used while the third party library is used to check if the name is valid. I added comments in the validation function explaining this to avoid confusion in the future. I had some problems with git but hopefully everything worked out well. Let me know what you think.

jakoblind commented 4 years ago

Looks good!

Just a minor UI thing. It's a bit too much space above the input field. maybe set margin-top: 20px; on the desktopOnly class?

Also, it would be nice to have the help icon to the right of the label, with a modal explaining what this field is used for. I can help with the help text, if you want.

linus345 commented 4 years ago

I wrote a help message for the project name input. Let me know if it's missing something or if it should be rewritten.

jakoblind commented 4 years ago

Awesome work, Linus. Well-written code and commit messages that are easy to read. I like it!