jakobw / wd-query-builder

Prototype of the Wikidata Query Builder for generating lists from Wikidata
https://tools.wmflabs.org/wd-query-builder/
GNU General Public License v2.0
8 stars 0 forks source link

Filter for “qualifier does not exist” doesn’t work #3

Open lucaswerkmeister opened 6 years ago

lucaswerkmeister commented 6 years ago
  1. Add a filter for any statement, e. g. “instance of: Wikidata”.
  2. Add a qualifier filter for any property, e. g. “end time”.
  3. For the qualifier value, select “does not exist”.
  4. Click “show results”.

Expected: results show up. (In this case, 0 results, but something should still happen.)

Actual: Nothing happens (no WDQS embed), and there are two errors in the console:

  1. When you select “does not exist”:

    [Vue warn]: Error in callback for watcher "valueType": "TypeError: specialValue.classConstructor is not a constructor"

    found in

    ---> at src/components/ValueSelector.vue

    at src/components/Qualifier.vue at src/components/Statement.vue at src/components/StatementList.vue at src/App.vue vue.esm.js:578 TypeError: specialValue.classConstructor is not a constructor Stack trace: newValue@webpack-internal:///22:21:16 valueType@webpack-internal:///41:126:26 run@webpack-internal:///1:3207:11 flushSchedulerQueue@webpack-internal:///1:2955:5 nextTick/<@webpack-internal:///1:1814:9 flushCallbacks@webpack-internal:///1:1735:5
  2. When you click “show results”:

    [Vue warn]: Error in nextTick: "TypeError: qualifier.getValue(...) is undefined" vue.esm.js:578 TypeError: qualifier.getValue(...) is undefined Stack trace: addQualifierTriples@webpack-internal:///142:59:87 generateQuery@webpack-internal:///142:25:7 generateQuery@webpack-internal:///51:56:14 boundFn@webpack-internal:///1:192:9 showResults/<@webpack-internal:///51:72:24 nextTick/<@webpack-internal:///1:1814:9 flushCallbacks@webpack-internal:///1:1735:5

jakobw commented 6 years ago

Thanks for reporting this! The "does not exist" special value isn't implemented yet unfortunately. I should probably document this somewhere and make sure that it doesn't completely crash. It's all still a little prototype-y and rough around the edges in a few places.

lucaswerkmeister commented 6 years ago

Ah, okay, I didn’t know that :)