jakoch / install-vulkan-sdk-action

A Github Action to install the current Vulkan SDK and runtime library.
MIT License
4 stars 3 forks source link

Add vulkansdk/bin to path #453

Open ThomasAunvik opened 1 month ago

ThomasAunvik commented 1 month ago

I noticed that here it is commented out:

https://github.com/jakoch/install-vulkan-sdk-action/blob/8578878e93982f505382ec58ca42a85a0b740639/src/main.ts#L142-L152

But the path that is added is not the bin folder, and only the install folder, which doesn't include all the executables that vulkansdk gives.

And I would not be able to execute glslc.

And the docs points to the bin folder, and not the install folder: image

https://vulkan.lunarg.com/doc/sdk/1.3.261.1/linux/getting_started.html#set-up-the-runtime-environment

In which case, I would have to add this as an alternative to my github action:

      - name: Setup Linux Env
        if: contains(runner.os, 'ubuntu')
        run: source $VULKAN_SDK/setup-env.sh

      - name: Setup Windows Env
        if: contains(runner.os, 'windows')
        run: $env:PATH += ";$env:VULKAN_SDK\Bin" # have not really found out how to fix it on windows, seems not working