search

jakopako / goskyr

A configurable command-line web scraper written in go with auto configuration capability
GNU General Public License v3.0
32 stars 4 forks source link

New JSON feature (minimal) with recommendations by @jakopako #226

Closed MarkJaroski closed 1 year ago

MarkJaroski commented 1 year ago

I've tested this code for regressions, but the real venue site I was testing the new feature with is down with a 505, so my next step will be to add a unit test for this.

jakopako commented 1 year ago

Awesome, thanks!

What's the reason that you added an 'install dependencies' step to the go-tests.yml file? The dependencies should be installed automatically in the 'Test' step.

MarkJaroski commented 1 year ago

Awesome, thanks!

What's the reason that you added an 'install dependencies' step to the go-tests.yml file? The dependencies should be installed automatically in the 'Test' step.

For some reasons the tests failed in my branch until I did that. It could be that the dependency files weren't yet correct.

jakopako commented 1 year ago

Awesome, thanks! What's the reason that you added an 'install dependencies' step to the go-tests.yml file? The dependencies should be installed automatically in the 'Test' step.

For some reasons the tests failed in my branch until I did that. It could be that the dependency files weren't yet correct.

hmmm ok. Yeah might be that the the dependency files weren't correct. I'll try without this extra step in the go-tests.yml file and if it fails, I'll re-add it.

jakopako commented 1 year ago

seems to work :)