jakowenko / double-take

Unified UI and API for processing and training images for facial recognition.
https://hub.docker.com/r/jakowenko/double-take
MIT License
1.21k stars 96 forks source link

Error messages popping up #313

Open tobiasbrage opened 1 year ago

tobiasbrage commented 1 year ago

mobile_error pc_error I've messed with Double Take for a couple of days, but out of nowhere i'm now getting some annoying error messages. They seem to not affect anything as Double Take still works just fine, they're just annoying and pops up every 30 seconds or so. The error message is different depending on what device I use. On my phone i'm getting "undefined is not an object (evaluating 'n.id')" and on my computer i'm getting "Cannot read properties of undefined (reading 'id')".

I've searched the log, no mention of these in there. Is this a deepstack issue?

Perkinje commented 1 year ago

I am seeing the same problem, also with no error showing in the double-take, compreface or deepstack logs.

townsmcp commented 1 year ago

Me too! It started popping up today when I go to the Match screen. Thought I had changed something to make this happen but all I have done is added a new zone in Frigate and added that to my DT config. Also, nothing in logs either.

The only thing that has changed on my HA install was to do with Yale integration issues from yesterday and a temporary patch - @Perkinje and @tobiasbrage have either of you installed the Yale lock patch?

tobiasbrage commented 1 year ago

When I come to think about it, the error messages started to appear after adding masks and zones to Frigate.

I do not have anything Yale installed no.

townsmcp commented 1 year ago

When I come to think about it, the error messages started to appear after adding masks and zones to Frigate.

I do not have anything Yale installed no.

Good to know. At least the Yale change is ruled out.

I have just commented out my masks and zones from Frigate and DT and restarted both - still showing the reading.id errors for me :(

Perkinje commented 1 year ago

The only thing that has changed on my HA install was to do with Yale integration issues from yesterday and a temporary patch - @Perkinje and @tobiasbrage have either of you installed the Yale lock patch?

I don't have a Yale lock, so I have not patched it. Also, I haven't changed my setup in over a week but this just started yesterday.

atv2016 commented 1 year ago

Same exact message here. Doesn't seem to affect it, but something's wrong obviously.

weilkevin commented 1 year ago

Screenshot 2023-05-19 160232 Mine is slightly different but it also just started appearing yesterday.

melnikovRV commented 1 year ago

Same message. i think its after HA 2023.5.3 update

Снимок экрана 2023-05-20 в 08 04 17
crazyhoesl commented 1 year ago

Same error since a couple of days. no frigate in my config.

pdobrien3 commented 1 year ago

following. I have the same issue. no idea when it started but haven't changed my double-take config in a while. i have been messing with the live stream settings in frigate.

Enc3ph4l0n commented 1 year ago

This error is appearing for me too. Whilst I haven't yet spent any time investigating why, I thought I could at least save others a wild goose chase.

I don't use Home Assistant so HA is irrelevant to this. I do use Frigate and CompreFace. However, I haven't upgraded DoubleTake, Frigate or Compreface for months. I have not changed any configurations for months. I've not added zones or masks. I've made no changes at all, for months.

I suspect the issue is in fact with DoubleTake itself. Seeing as this project has gone unloved and not been updated for some time - it got me thinking of external calls it could be making - I wondered if it is the telemetry call failing, but I have that deactivated so it shouldn't be running at all.

I'd like to find some time to debug, but hope that helps anyone currently looking at it.

Mincka commented 1 year ago

I though it was analytics since there's a call to this endpoint that is failing (404) in the browser's console: https://analytics.jako.io/api/event

But every minute, the error pops up on this specific request: URL: https://api.github.com/repos/jakowenko/double-take/actions/runs

  curl 'https://api.github.com/repos/jakowenko/double-take/actions/runs' \
  -H 'authority: api.github.com' \
  -H 'accept: application/json' \
  -H 'accept-language: en,fr;q=0.9,en-US;q=0.8' \
  -H 'cache-control: no-cache' \
  -H 'dnt: 1' \
  -H 'origin: https://xxx' \
  -H 'pragma: no-cache' \
  -H 'referer: https://xxx/' \
  -H 'sec-ch-ua: "Microsoft Edge";v="113", "Chromium";v="113", "Not-A.Brand";v="24"' \
  -H 'sec-ch-ua-mobile: ?0' \
  -H 'sec-ch-ua-platform: "Windows"' \
  -H 'sec-fetch-dest: empty' \
  -H 'sec-fetch-mode: cors' \
  -H 'sec-fetch-site: cross-site' \
  -H 'user-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/113.0.0.0 Safari/537.36 Edg/113.0.1774.50' \
  --compressed

This request is created here in the code: https://github.com/jakowenko/double-take/blob/master/frontend/src/components/Toolbar.vue#L181

It's for the version check and my guess is that it fails because the script cannot find the latest workflow run related to a release (7 months ago for v1.13.1). The API only returns the 30 latest runs and they are periodically replaced by scheduled CodeQL runs (every Wednesday). https://github.com/jakowenko/double-take/actions

That's why we all see this error since the latest CodeQL run that happened exactly on May 17th 10:34PM GMT+2. This error will come back each time there's a gap of 30 weeks without a new release.

If you're crazy enough like me, you can SSH into your container, install VIM and remove the call of the version check method in the minified JS file.

root@dd03e537b2c2:/double-take/frontend/js# vi index.a791de4e.js

Find and delete , await this.checkVersion() (with the comma), save. Error gone.

I also started an image build on a fork with just this patch but it seems to take 2 hours... I will post the URL to the fixed image here if it succeeds, but it will be only for test purpose.

Edit: Docker image with fix: https://hub.docker.com/r/jehrhart/double-take HA image repo with fix: https://github.com/Mincka/double-take-hassio-addons/ image

townsmcp commented 1 year ago

@Mincka amazimg work. Thank you for sharing. I’m going to give your steps a try if the test fork doesn’t work

pdobrien3 commented 1 year ago

seems to have worked for me. thank you

Mincka commented 1 year ago

It looks like I managed to build an image with the fix (I guess, not tested it myself). ARMv7 (32-bit) was removed because it breaks the build. Use at your own risk: https://hub.docker.com/repository/docker/jehrhart/double-take/general

townsmcp commented 1 year ago

I though it was analytics since there's a call to this endpoint that is failing (404) in the browser's console: https://analytics.jako.io/api/event

But every minute, the error pops up on this specific request: URL: https://api.github.com/repos/jakowenko/double-take/actions/runs

@Mincka Well dont I feel stupid. Brought to a stop at the first task ' SSH into your container, install VIM and remove the call of the version check method in the minified JS file.'. Is there any chance you can write out step by step what you did to do this? I cant seem to SSH into the container - I have just installed 'Advanced SSH & Web Terminal' but cant seem to get that to run :( when I try and go into 'Terminal & SSH' Im stumped as I cant 'docker ps' to see the name of the DT container :(

pdobrien3 commented 1 year ago

Try using putty and you may need to dosudo docker ps -a docker exec -it double-take /bin/bash apt install nano ( I like nano) cd /double-take/frontend/js nano index.a791de4e.js ctl+sft+w and search for checkVersion() delete the string ctl o + enter ctl x exit

townsmcp commented 1 year ago

@pdobrien3 thank you. I prefer nano as well. I use Termius (due to being on a Mac). I have SSH'd in and get the following when doing docker ps -a or sudo docker ps -a:

image

EDIT - think I might have it. My HA is running on Proxmox. docker ps -a is showing me all the running containers from Proxmox console :)

townsmcp commented 1 year ago

@pdobrien3 thank you so much - that worked. @Mincka thank you for finding the solution - this worked for me as well :)

atv2016 commented 1 year ago

So what’s the fix here for those running doubketake as an add on with hassos? Edit the files directly?

Even if you edit it in your docker container, won’t it be void once the container restarts?


From: James T @.> Sent: 24 May 2023 21:24 To: jakowenko/double-take @.> Cc: atv2016 @.>; Comment @.> Subject: Re: [jakowenko/double-take] Error messages popping up (Issue #313)

@pdobrien3https://github.com/pdobrien3 thank you so much - that worked. @Minckahttps://github.com/Mincka thank you for finding the solution - this worked for me as well :)

— Reply to this email directly, view it on GitHubhttps://github.com/jakowenko/double-take/issues/313#issuecomment-1561880608, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEBCFU7JTGHUTDLDTO6R72DXHZVARANCNFSM6AAAAAAYFWV7MU. You are receiving this because you commented.Message ID: @.***>

pdobrien3 commented 1 year ago

Is the add-on maintained by someone other that double-take? If the add-on is active, you can open an issue with the maintainer. Also, the modifications above persist a container restart.

atv2016 commented 1 year ago

That’s @@.***> unfortunately.


From: pdobrien3 @.> Sent: 25 May 2023 10:52 To: jakowenko/double-take @.> Cc: atv2016 @.>; Comment @.> Subject: Re: [jakowenko/double-take] Error messages popping up (Issue #313)

If the add-on is active, you can open an issue with the maintainer.

— Reply to this email directly, view it on GitHubhttps://github.com/jakowenko/double-take/issues/313#issuecomment-1562615755, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEBCFU6KRDNHZKIFQOVQKBLXH4TU7ANCNFSM6AAAAAAYFWV7MU. You are receiving this because you commented.Message ID: @.***>

Mincka commented 1 year ago

All of this is not tested and you will lose all your data and configuration if you uninstall the addon.

For HA Addons, you can try to add this experimental repo: https://github.com/Mincka/double-take-hassio-addons/

And install this add-on (which is based on my docker image with the fix): image

atv2016 commented 1 year ago

Nice, i might try that. Thanks!


From: Julien Ehrhart @.> Sent: 25 May 2023 15:09 To: jakowenko/double-take @.> Cc: atv2016 @.>; Comment @.> Subject: Re: [jakowenko/double-take] Error messages popping up (Issue #313)

For HA Addons, you can try to add this experimental repo: https://github.com/Mincka/double-take-hassio-addons/

And install this add-on (which is based on my docker image with the fix): [image]https://user-images.githubusercontent.com/6184289/240937262-cd6f2b03-7ca1-42a6-b30b-331ccdb1044b.png

All of this is not tested and you will lose all your configuration if you uninstall the addon.

— Reply to this email directly, view it on GitHubhttps://github.com/jakowenko/double-take/issues/313#issuecomment-1562979323, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEBCFU6JKBXFPQAZR6DUTG3XH5R2XANCNFSM6AAAAAAYFWV7MU. You are receiving this because you commented.Message ID: @.***>

645340633 commented 1 year ago

Have it solved?

townsmcp commented 1 year ago

Removing the code snippet stopped one error I was getting but I started getting a different error message. I installed Mincka version, set the config to my old settings and no more error messages since

Dvalin21 commented 1 year ago

I don't even have double take addon for Hassio, but I get the error undefined (read id).

Mincka commented 1 year ago

I don't even have double take addon for Hassio, but I get the error undefined (read id).

So read the thread or try this image with a fix.

atv2016 commented 1 year ago

@Mincka i'm using your image now but it seems it just creeps up in CPU or RAM over time, i don't think this is your image, but just double take. It's just doing 50% cpu all the time. I don't remember if this started before or after a HA update really. If i turn it off my cpu is at a nice calm 5-9 %.

Mincka commented 1 year ago

@Mincka i'm using your image now but it seems it just creeps up in CPU or RAM over time, i don't think this is your image, but just double take. It's just doing 50% cpu all the time. I don't remember if this started before or after a HA update really. If i turn it off my cpu is at a nice calm 5-9 %.

I think you should open a dedicated issue for this. Like you said, it does not seem related to this bug or the fix that just removes one line of code.

Dvalin21 commented 1 year ago

I don't even have double take addon for Hassio, but I get the error undefined (read id).

So read the thread or try this image with a fix.

Im assuming the docker compose is or cli is the same? Thanks

Mincka commented 1 year ago

Yes, with image: jehrhart/double-take.

twister36 commented 1 year ago

It appears this doesn't affect anything, is just an annoying, correct?

Mincka commented 1 year ago

It appears this doesn't affect anything, is just an annoying, correct?

Yes

superdong69 commented 12 months ago

How is this still an issue in the most current code if this has been reported as resolved?

I just installed completely fresh, and I'm getting this error every 60 secs. How are you supposed to rectify this on a HAAOS installed addon?

Dvalin21 commented 12 months ago

How is this still an issue in the most current code if this has been reported as resolved?

I just installed completely fresh, and I'm getting this error every 60 secs. How are you supposed to rectify this on a HAAOS installed addon?

Try https://github.com/skrashevich/double-take

superdong69 commented 12 months ago

How is this still an issue in the most current code if this has been reported as resolved? I just installed completely fresh, and I'm getting this error every 60 secs. How are you supposed to rectify this on a HAAOS installed addon?

Try https://github.com/skrashevich/double-take

Which one is the real creator? Is it not jakowenko?

Dvalin21 commented 12 months ago

How is this still an issue in the most current code if this has been reported as resolved? I just installed completely fresh, and I'm getting this error every 60 secs. How are you supposed to rectify this on a HAAOS installed addon?

Try https://github.com/skrashevich/double-take

Which one is the real creator? Is it not jakowenko?

Its, skrashevich forked and continuing the work

superdong69 commented 12 months ago

How is this still an issue in the most current code if this has been reported as resolved? I just installed completely fresh, and I'm getting this error every 60 secs. How are you supposed to rectify this on a HAAOS installed addon?

Try https://github.com/skrashevich/double-take

Which one is the real creator? Is it not jakowenko?

Its, skrashevich forked and continuing the work

Oh that's great info, I didn't know this project was dunn-zo.

superdong69 commented 11 months ago

How is this still an issue in the most current code if this has been reported as resolved? I just installed completely fresh, and I'm getting this error every 60 secs. How are you supposed to rectify this on a HAAOS installed addon?

Try https://github.com/skrashevich/double-take

Which one is the real creator? Is it not jakowenko?

Its, skrashevich forked and continuing the work

Real quick and stupid question, is there a way to switch my server to this version without having to uninstall, reinstall?

Dvalin21 commented 11 months ago

How is this still an issue in the most current code if this has been reported as resolved? I just installed completely fresh, and I'm getting this error every 60 secs. How are you supposed to rectify this on a HAAOS installed addon?

Try https://github.com/skrashevich/double-take

Which one is the real creator? Is it not jakowenko?

Its, skrashevich forked and continuing the work

Real quick and stupid question, is there a way to switch my server to this version without having to uninstall, reinstall?

I would say no. However, I could be wrong. Just make sure to keep your config, and training folder.

Mincka commented 11 months ago

How is this still an issue in the most current code if this has been reported as resolved? I just installed completely fresh, and I'm getting this error every 60 secs. How are you supposed to rectify this on a HAAOS installed addon?

Try https://github.com/skrashevich/double-take

Which one is the real creator? Is it not jakowenko?

Its, skrashevich forked and continuing the work

Real quick and stupid question, is there a way to switch my server to this version without having to uninstall, reinstall?

If you are using the container, I literally just replaced jawenko by skrashevich in the name image: skrashevich/double-take. It worked without any other change.

superdong69 commented 11 months ago

How is this still an issue in the most current code if this has been reported as resolved? I just installed completely fresh, and I'm getting this error every 60 secs. How are you supposed to rectify this on a HAAOS installed addon?

Try https://github.com/skrashevich/double-take

Which one is the real creator? Is it not jakowenko?

Its, skrashevich forked and continuing the work

Real quick and stupid question, is there a way to switch my server to this version without having to uninstall, reinstall?

If you are using the container, I literally just replaced jawenko by skrashevich in the name image: skrashevich/double-take. It worked without any other change.

Thank you!