search

jakub-g / gh-code-review-assistant

:octocat: (no longer maintained) GitHub Code Review Assistant tool is a userscript (lightweight extension) for Firefox / Chrome
Other
27 stars 8 forks source link

Hiding files matching a pattern #22

Open jakub-g opened 10 years ago

jakub-g commented 10 years ago

As suggested on http://userscripts.org/topics/214851 by @greenkiwi

I'm wondering what to do with those files. Currently the files can be in 3 states: not touched (light gray), reviewed (black), failed (red)

Some options

  1. automatically mark those files with a color for "reviewed" and effectively put them in "reviewed" state state (it means they'll not be expanded upon clicking "expand unreviewed") - but then you can still review them manually if you really want
  2. mark them with yet some other color / don't mark them, but keep them in some other state, so they're never expanded unless you do it manually (adds some complexity)

I think I'd probably go with 1)

greenkiwi commented 10 years ago

Hi Jake,

It might be worth having an option to select between 1 & 2 (or two lists). I know that for us, we would simply want to have it in a second state (of being display:none), maybe with an option to show all. Our goal is to just remove the distraction so that you only see the files you need to review.

I can definitely see other situation where you'd want to "auto-mark reviewed".

-Adam

On Thu, Apr 24, 2014 at 2:50 AM, jakub-g notifications@github.com wrote:

As suggested on http://userscripts.org/topics/214851 with @greenkiwihttps://github.com/greenkiwi

I'm wondering what to do with those files. Currently the files can be in 3 states: not touched (light gray), reviewed (black), failed (red)

Some options

  1. automatically mark those files with a color for "reviewed" and effectively put them in "reviewed" state state (it means they'll not be expanded upon clicking "expand unreviewed") - but then you can still review them manually if you really want
  2. mark them with yet some other color / don't mark them, but keep them in some other state, so they're never expanded unless you do it manually (add some complexity)

I think I'd probably go with 1)

Reply to this email directly or view it on GitHubhttps://github.com/jakub-g/gh-code-review-assistant/issues/22 .