search

jakub-g / gh-code-review-assistant

:octocat: (no longer maintained) GitHub Code Review Assistant tool is a userscript (lightweight extension) for Firefox / Chrome
Other
27 stars 8 forks source link

Fixed selectors for some class changes that Github made #31

Closed csudcy closed 9 years ago

csudcy commented 9 years ago

Github decided to change some CSS classes so I've updated the selectors used in the script. I've tested it using Tampermonkey on Chrome with pulls, commits and compares. Also, updated the version so it will get auto updated.

jakub-g commented 9 years ago

Awesome, I've seen it breaking this week but I had no time to investigate it.

Quickly looking at the PR, please also change the version from 1.0.3 to 1.0.4 in both files, and update CHANGELOG.txt accordingly

I'll test it later and merge if it's fine

Thanks!

jakub-g commented 9 years ago

Oh, actually I'd prefer to have a version-bump as a separate commit like here

https://github.com/jakub-g/gh-code-review-assistant/commit/c64070961b77ea7b5ffc748e5cf89ec12ce2413c

so that it's easily visible when I do git log

https://github.com/jakub-g/gh-code-review-assistant/commits/next

csudcy commented 9 years ago

Cool; hope that's good now :+1:

jakub-g commented 9 years ago

Merged and pushed to master, should now auto-update for all the users. Thanks!

csudcy commented 9 years ago

Awesome :smiley: BTW, thank you for making a very useful tool which, IMHO, should be a builtin feature of Github!

jakub-g commented 9 years ago

Feel invited to let others know and star the project ;)