jakub-g / gh-code-review-assistant

:octocat: (no longer maintained) GitHub Code Review Assistant tool is a userscript (lightweight extension) for Firefox / Chrome
Other
27 stars 8 forks source link

SHA1 should be the GUID for commits, not repo+SHA1 #9

Closed jakub-g closed 10 years ago

jakub-g commented 10 years ago

Regarding commits, the SHA1 should be the sufficient GUID in the local storage. Now the whole URI is the GUID which makes the code review status be displayed only in the fork and not in the original repo, when browsing it. For instance:

https://github.com/ymeine/ariatemplates/commit/a301e7b42e8d7204394a4e2fd56eec347a640915 https://github.com/ariatemplates/ariatemplates/commit/a301e7b42e8d7204394a4e2fd56eec347a640915

This is the same commit but across two forks