Course vs Lecture naming

jakub-tucek / fit-checker

Fit-checker 2.0 for CTU FIT

MIT License

1 stars 0 forks source link

Course vs Lecture naming #18

Closed jakub-tucek closed 7 years ago

jakub-tucek commented 7 years ago

Current state: both naming is present which is unfortunate. Which will we use? And refactor rest? I think We should pick option will be more easy to refactor.

jakub-tucek commented 7 years ago

In *.swift

Course (whole word) - 25 matches in 8 files
Lecture (whole word) - 35 matches in 8 files
Lecture - 124
Course - 120

josefdolezal commented 7 years ago

Hah, just made the same statistic. We should definitely pick one and keep it as convention. I used Course instead of Lecture because this convention is used on Edux.

If we move to Lecture, we should also rename parser objects and save short names (as Lecture) for model objects instead.

I also asked my friend who is native speaker about his opinion. So lets wait we will decide later..

jakub-tucek commented 7 years ago

Decided to use Course instead of Lecture. I will do refactor.

jakub-tucek commented 7 years ago

Changes in Feature/lecture-rename-course branch