search

jakubfiala / atrament

A small JS library for beautiful drawing and handwriting on the HTML Canvas.
http://fiala.space/atrament/demo
MIT License
1.56k stars 115 forks source link

Using 'fill' tool on a section that is already filled crashes browser tab #22

Closed ianschmitz closed 7 years ago

ianschmitz commented 7 years ago

Easy enough to repro:

  1. Open demo at http://fiala.uk/atrament.js/demo/
  2. Select 'fill' tool
  3. Fill the canvas by clicking on the page
  4. Fill again by clicking on the page
  5. Notice the crash!
jakubfiala commented 7 years ago

@ianschmitz thanks for flagging this up, seems like I haven't thought about the possibility of refilling with the same colour when testing :) gonna get rid of this nasty infinite loop asap.

jakubfiala commented 7 years ago

@ianschmitz fyi this may be fixed in #24