Feature/eslint ruben - Githubissues

jakubfiala / atrament

A small JS library for beautiful drawing and handwriting on the HTML Canvas.

http://fiala.space/atrament/demo

MIT License

1.56k stars 115 forks source link

Closed rubenstolk closed 7 years ago

rubenstolk commented 7 years ago

Hey @jakubfiala this is the style that I usually use, it catches a few more issues like forcing you to use const etc.

Anyways, I'm also happy with your PR, I'm not too particular :)

jakubfiala commented 7 years ago

cool, the only rules I'd have a problem with are:

space-before-function-paren because I just like not having that space :)
no-alert because there shouldn't really ever be a reason to use alert, you can replicate its dev usefulness purely using console and debugger if needed.

If you're ok with removing these rules, I'm happy to merge!

rubenstolk commented 7 years ago

Oh sure! Done!

jakubfiala commented 7 years ago

awesome, cheers! merging this and closing the other PR.