search

jakubfiala / atrament

A small JS library for beautiful drawing and handwriting on the HTML Canvas.
http://fiala.space/atrament/demo
MIT License
1.55k stars 116 forks source link

Do not reset canvas size to 500x500 #30

Closed raphinesse closed 5 years ago

raphinesse commented 7 years ago

IMHO, giving no width and height at all to atrament should not reset the dimensions of the canvas element. It is quite unexpected, not to say irritating.

In case you need the dimensions internally, you should instead read them from the canvas element.

jakubfiala commented 7 years ago

well the idea was that you should always set the internal canvas size when creating Atrament. But yeah, I guess hard-coding the default values is odd.

raphinesse commented 7 years ago

Is there a reason why the size should be supplied to atrament?

jakubfiala commented 5 years ago

this is fixed in v0.3.0 🎉