search

jakubfiala / atrament

A small JS library for beautiful drawing and handwriting on the HTML Canvas.
http://fiala.space/atrament/demo
MIT License
1.56k stars 115 forks source link

beginDrawing/stopDrawing do not record mouse positions #45

Closed ghost closed 4 years ago

ghost commented 4 years ago

https://github.com/jakubfiala/atrament.js/blob/59d3e6767b0b27e555c215e906993a616ea1d408/src/atrament.js#L151

jakubfiala commented 4 years ago

Hi @coranos - thanks for submitting this and #46. I will make it so the start/end positions are recorded, and also provided to strokestart/strokeend events

ghost commented 4 years ago

cool. if you are interested, here is my demo for 'undo'

https://coranos.github.io/bananos/sketch/

jakubfiala commented 4 years ago

Hey @coranos - this should now be fixed in v1.1.0. Feel free to reopen if you still encounter issues.

N.B. I decided to rename begin/endDrawing to begin/endStroke so the names are more descriptive of what the methods actually do.