search

jakubfiala / atrament

A small JS library for beautiful drawing and handwriting on the HTML Canvas.
http://fiala.space/atrament/demo
MIT License
1.55k stars 116 forks source link

mouseUp only triggers if mouse.down #58

Closed future-cyborg closed 3 years ago

future-cyborg commented 4 years ago

Great library!

This fixes a couple undesirable behaviors.

  1. Any click outside the canvas results in strokeend and strokerecorded being called.
  2. If you mouseDown outside of the canvas and mouseUp inside the canvas, you get undesirable strokes.

This enforces that a stroke is only started by a click inside the canvas.

jakubfiala commented 3 years ago

thanks for the contribution @future-cyborg - I'll test this today and if all is well, merge and release a new version of the library