Added a disabled option to DrawingMode

jakubfiala / atrament

A small JS library for beautiful drawing and handwriting on the HTML Canvas.

http://fiala.space/atrament/demo

MIT License

1.55k stars 116 forks source link

Added a disabled option to DrawingMode #61

Closed uriberto closed 3 years ago

uriberto commented 3 years ago

This just lets the instance set mode to 'disabled'. In that case, no draw/fill/erase should be triggered on mouse move. I wasn't sure if this use case should allow strokes to be created/recorded under disabled mode, so I didn't touch that.

jakubfiala commented 3 years ago

Hi there @uriberto! thanks for creating both the issue and the PR, really appreciate it. I think this is a great addition to Atrament.

I'm unfortunately quite busy these days, but I'll try to review the PR and test everything + update the docs and release a new minor version in the next week or two. Hope that's ok!

uriberto commented 3 years ago

No prob. I'm glad you agree this would be a nice addition. There's no hurry from my perspective. I don't have any immediate need for this. I just thought it would be a nice option to have. Thanks.