search

jakubfiala / atrament

A small JS library for beautiful drawing and handwriting on the HTML Canvas.
http://fiala.space/atrament/demo
MIT License
1.55k stars 116 forks source link

point drawn event #78

Closed profispojka closed 1 year ago

profispojka commented 2 years ago

Added a pointdrawn event to be able to watch drawing in realtime.

profispojka commented 2 years ago

Hi. Is there anything missing from the pull request? Could I somehow help with the merging process?

profispojka commented 2 years ago

Hi @jakubfiala. When do you think this could be merged?

MentalGear commented 2 years ago

This is great, thx @profispojka . Since you have knowledge on draw eventsm any chance you could also take a look at https://github.com/jakubfiala/atrament.js/issues/53 ?

profispojka commented 2 years ago

@MentalGear Well, if this merge request will be merged, I could then have a look.

profispojka commented 1 year ago

So, can this be merged? @jakubfiala

jakubfiala commented 1 year ago

@profispojka I'm really sorry I have not been responsive in the last year, I let things slip a bit and couldn't focus on maintaining the library. I'm going to review the PR and merge it on Monday, I've planned some time for Atrament maintenance then. Thank you for your patience and perseverance :)

jakubfiala commented 1 year ago

@profispojka thank you for the PR! I do want to include this new event, but I think I'd like to implement it slightly differently, so some of the existing code is reused. Will open another PR and tag you in it so you're kept in the loop :) thanks again!