search

jakubg1 / OpenSMCE

Game engine which allows creating a broad range of marble popper games.
MIT License
14 stars 11 forks source link

Code inconsistency: some classes state their settings as "settings", and other as "config" #27

Closed jakubg1 closed 3 years ago

jakubg1 commented 3 years ago

Take a look at the code and rename the variables accordingly.

Classes known to have their settings named settings:

Classes known to have their settings named config:

TL;DR: Rename settings to config in Shooter.lua and Scorpion.lua.

jakubg1 commented 3 years ago

Partially done: renamed settings to config in Shooter and SphereGroup. https://github.com/jakubg1/OpenSMCE/commit/03001ff9f5307cfbbbf6a2b56143adcd083bbe17

jakubg1 commented 3 years ago

Renamed settings to config in BonusScarab and Scorpion. https://github.com/jakubg1/OpenSMCE/commit/56bb23eb87c80ade0ed4fa48be82263cef4b505d

Needs checking if that's it.

jakubg1 commented 3 years ago

It seems that there are no more occurrences of settings that need to be renamed. Fixed.