search

jakubgarfield / Bonobo-Git-Server

Bonobo Git Server for Windows is a web application you can install on your IIS and easily manage and connect to your git repositories. Go to homepage for release and more info.
http://bonobogitserver.com
MIT License
1.81k stars 603 forks source link

Commit message length on Commits page #387

Open carlosefonseca opened 8 years ago

carlosefonseca commented 8 years ago

I've been using commit messages with 50 chars for the title since that's somewhat standard with git but on Bonobo's Commit page for a Repository, the titles for the commits are limited to ~35 chars.

This is a bit annoying since it becomes common to have a couple of words hidden while having plenty of white space…

I took a quick look at the code and I think the problem is here https://github.com/jakubgarfield/Bonobo-Git-Server/blob/master/Bonobo.Git.Server/RepositoryBrowser.cs#L287

And, just a little bit above, you seem to be using the 50 char limit somewhere else https://github.com/jakubgarfield/Bonobo-Git-Server/blob/master/Bonobo.Git.Server/RepositoryBrowser.cs#L233

jakubgarfield commented 8 years ago

It might be limited due to use in other places and restrictions in UI.

willdean commented 8 years ago

Could this be done on the commit page entirely client-side? I.e. let the browser work out where to to put the overflow ellipsis, and then have the [...] button expand that div to show the whole message.

It's rather strange at the moment anyway, as when you expand it the 'overflow' text appears below the timestamp and in a completely different font - often it's only one or two words, which look completely odd down there on their own. (I realise now that this is how GitHub does it, though)

To me, GitLab seems to have this better - see for example https://gitlab.com/gitlab-org/gitlab-ce/commits/master . They get hugely more onto the screen than Bonobo - they can get masses of commit line in without truncating it, and the expansion seems neater too. They do have a bug where the expansion button disappears at certain window widths, though...