jakubgarfield / Bonobo-Git-Server

Bonobo Git Server for Windows is a web application you can install on your IIS and easily manage and connect to your git repositories. Go to homepage for release and more info.
http://bonobogitserver.com
MIT License
1.81k stars 603 forks source link

Bundled curl version cannot support posting webhooks to slack since they require TLS v1.2 #861

Open esontag opened 4 years ago

esontag commented 4 years ago

I have a githook that is based on this script

https://github.com/joemiller/git-hooks

and was working fine for years.

Effective 3/4/2020, slack ended support for TLS 1.0 and 1.1

The version of curl that is being used by the bonobo git server is incapable of submitting http requests that comply.

It's really handy to be able to share commit messages via slack and this feature would be great to get back.

The error we're getting is:

C:\inetpub\wwwroot\Bonobo.Git.Server\App_Data\Git>curl -H "content-type: application/json" -d '{"text": "test","fallback":"test1"}' https://hooks.slack.com/services/xxx/yyy
curl: (3) [globbing] unmatched close brace/bracket in column 20
curl: (35) error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version

I've confirmed this works in version:

curl 7.68.0 (x86_64-w64-mingw32) libcurl/7.68.0 OpenSSL/1.1.1d (Schannel) zlib/1.2.11 libidn2/2.3.0 libssh2/1.9.0 nghttp2/1.40.0 Release-Date: 2020-01-08 Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps pop3 pop3s rtsp scp sftp smtp smtps telnet tftp Features: AsynchDNS HTTP2 HTTPS-proxy IDN IPv6 Kerberos Largefile libz Metalink MultiSSL NTLM SPNEGO SSL SSPI TLS-SRP

Here's is a sample of it working: `` $ curl -H "content-type: application/json" -d '{"text": "test","fallback":"test1"}' https://hooks.slack.com/services/xxx/yyy/zzz % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 37 0 2 100 35 13 233 --:--:-- --:--:-- --:--:-- 248ok


Thank you in advance.
exxocism commented 12 months ago

Yeah 👍 We need to replace this one