Bump php dep to ~8.0 - Githubissues

jakubkulhan / bunny

Performant pure-PHP AMQP (RabbitMQ) sync/async (ReactPHP) library

MIT License

702 stars 102 forks source link

Bump php dep to ~8.0 #101

Closed standa closed 3 years ago

standa commented 3 years ago

This would really help us. Thanks! :)

janlanger commented 3 years ago

Bunny contains required parameters after optional, which is deprecated since PHP 8 and emits E_DEPRECATED. It's in ClientMethods for example.

Also, testing on PHP 8 should probably be set up on Travis.

WyriHaximus commented 3 years ago

@standa cool thanks for this PR :+1: ! Not sure yet why the Travis build isn't started.

edudobay commented 3 years ago

Hi! I've addressed these issues in another PR: https://github.com/jakubkulhan/bunny/pull/102. Feel free to incorporate any changes from there. Please note that there is a PHP 7.0 compatibility issue.

standa commented 3 years ago

Hi @edudobay, thank you for picking this up. I think my PR became redundant by you creating yours. So I am closing mine as a lesser one.