Case insensitive error_get_last() check

jakubkulhan / bunny

Performant pure-PHP AMQP (RabbitMQ) sync/async (ReactPHP) library

MIT License

698 stars 101 forks source link

Case insensitive error_get_last() check #125

Closed wizu closed 1 year ago

wizu commented 2 years ago

On my system I get "stream_select(): Unable to select [4]: Interrupted system call (max_fd=4)" where "Unable" starts with capital letter, which break this check

mermshaus commented 1 year ago

I can confirm this.

The “unable” → “Unable” change in the stream_select() error message seems to have happened with PHP 8.

It would be great if this PR could be merged and be released as a patch release. Right now, it’s probably not possible to cleanly disconnect a synchronous Bunny client on SIGINT/SIGTERM when using PHP 8.

WyriHaximus commented 1 year ago

Thank you for filing this fix @wizu, went with the PR @mermshaus created instead.