jakubkulhan / bunny

Performant pure-PHP AMQP (RabbitMQ) sync/async (ReactPHP) library
MIT License
706 stars 102 forks source link

Add test to illustrate #125 (stream_select/interrupt issue). Also a fix #128

Closed mermshaus closed 2 years ago

mermshaus commented 2 years ago

(This is based on #127. Only the commits starting with “Improve code structure in tests. Add test to illustrate #125” are new.)

This PR adds a test to show the issue from #125. With some of the commits, the test intentionally fails for all PHP 8 checks. See here for example.

For good measure, I also added the smallest possible fix. This would make #125 obsolete. Hope that’s okay for everyone.

@WyriHaximus If you need more info, just get back to me in some way (e.g. @merms@mastodon.social). I’d really like to have this merged. :slightly_smiling_face: